Skip to content

refactor(styles): replace Sass with plain CSS and Tailwind @apply#8159

Merged
alexander-akait merged 5 commits intowebpack:mainfrom
sujalgoel:refactor/remove-sass
Apr 3, 2026
Merged

refactor(styles): replace Sass with plain CSS and Tailwind @apply#8159
alexander-akait merged 5 commits intowebpack:mainfrom
sujalgoel:refactor/remove-sass

Conversation

@sujalgoel
Copy link
Copy Markdown
Contributor

Summary

Completes #8047. Removes all Sass from the project and replaces it with plain CSS using Tailwind @apply.

  • Converted src/styles/index.scss to src/styles/index.css
  • Converted src/styles/dark.scss to src/styles/dark.css
  • Deleted src/styles/partials/ (vars, functions, mixins) — all values inlined or replaced with Tailwind utilities
  • Added @reference "tailwindcss" to both files for @apply support
  • Updated src/components/Site/Site.jsx to import index.css
  • Removed the scss webpack rule and sass-loader from webpack.common.mjs
  • Removed sass, sass-loader, and modularscale-sass from package.json
  • Removed .scss from resolve.extensions and lint-staged glob

What kind of change does this PR introduce?

Refactor. No behavior or visual changes.

Did you add tests for your changes?

No.

Does this PR introduce a breaking change?

No.

If relevant, what needs to be documented once your changes are merged or what have you already documented?

N/A

Use of AI

No.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-js-org Ready Ready Preview, Comment Apr 3, 2026 1:01pm

Request Review

Comment thread package.json Outdated
"sitemap-static/minimist": "1.2.5",
"eval": "^0.1.5"
"eval": "^0.1.5",
"lodash": "4.18.1"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it from here

Comment thread src/styles/index.css
@@ -0,0 +1,67 @@
@reference "tailwindcss";
@import url("https://fonts.googleapis.com/css2?family=Source+Code+Pro:wght@400;600&family=Source+Sans+Pro:ital,wght@0,400;0,600;1,400&family=Source+Serif+Pro:wght@600&display=swap");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you added it? Is it AI generated?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already in the original index.scss! Check line 7 of src/styles/index.scss before this PR: https://github.com/webpack/webpack.js.org/blob/d2a98529e9f/src/styles/index.scss#L7

@alexander-akait alexander-akait merged commit c961dc2 into webpack:main Apr 3, 2026
9 checks passed
@alexander-akait
Copy link
Copy Markdown
Member

Thanks

@sujalgoel
Copy link
Copy Markdown
Contributor Author

Thanks

no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants