-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: Improve footer legal links with lighter blue styling and subtle hover effect #8145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ const footerLinkClasses = | |
|
|
||
| const Footer = () => ( | ||
| <footer className="w-full flex-[0_0_auto] print:hidden"> | ||
| <Container className="mx-auto max-w-[900px] px-5 pb-[30px] pt-[40px] text-center [&_a]:text-[#3b7eb5]"> | ||
| <Container className="mx-auto max-w-[900px] px-5 pb-[30px] pt-[40px] text-center [&_a]:text-[#63a7de] [&_a]:transition-colors [&_a:hover]:text-[#89c2eb] [&_a:hover]:underline"> | ||
| <div className="mb-[24px] flex justify-center"> | ||
| <a href="https://openjsf.org" target="_blank" rel="noopener noreferrer"> | ||
|
||
| <img | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new default link color (#63a7de) (and the hover color #89c2eb) on the footer’s white background appears to fall below WCAG AA contrast for normal-sized text (Site uses
bg-white). This is an accessibility regression for the legal/copyright links. Consider using a darker blue (or a theme token) that meets contrast requirements, and avoid making the hover state even lower-contrast than the default.