fix(print): migrate Print component from BEM to Tailwind CSS#8110
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Mar 23, 2026
Merged
fix(print): migrate Print component from BEM to Tailwind CSS#8110alexander-akait merged 1 commit intowebpack:mainfrom
alexander-akait merged 1 commit intowebpack:mainfrom
Conversation
Replace BEM classes (sidebar-item, sidebar-item--disabled, sidebar-item__toggle, sidebar-item__title) with equivalent Tailwind utilities to match the SidebarItem refactor and support dark mode.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexander-akait
approved these changes
Mar 23, 2026
Member
|
@ryzrr Looks like we have problems with margin on |
Contributor
Author
|
yes , fixing it ASAP . |
Contributor
Author
|
Is the issue only in vercel preview or also in the production ? |
Member
|
@ryzrr everywhere |
Contributor
Author
@alexander-akait The gaps are perfectly fine here with the latest fix of the print component, it is only on the vercel preview and may be because of our fix/print-tailwind-migration PR was on a separate branch from our refactor PR, it didn't have our Tailwind fixes yet. It was stuck using main's broken SCSS so this can be a reason for this .
|
Member
|
@ryzrr oh yeah, I see, thanks for investigation |
Contributor
Author
|
No Problem, Happy to help! Let me know if there's anything else you need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrated the Print component from BEM classes to Tailwind utilities, adding dark mode support.
What kind of change does this PR introduce?
Print was using the old sidebar-item BEM class names removed in the SidebarItem refactor. Updated to matching Tailwind classes so it renders consistently in both light and dark mode.
Did you add tests for your changes?
No ,the component logic is unchanged, only the class names.
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented?
N/A
Use of AI ?
NA