Skip to content

style(PageLinks): improve dark-mode link contrast and tighten top spacing #8108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 5 commits into from
Mar 23, 2026
Merged

style(PageLinks): improve dark-mode link contrast and tighten top spacing #8108

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b83cb4
Tweak PageLinks styles and spacing
Deven14125 Mar 23, 2026
a63b232
Refine PageLinks styling and spacing
Deven14125 Mar 23, 2026
0c9f2ad
Lighten PageLinks link color
Deven14125 Mar 23, 2026
1e8c4eb
Merge branch 'fix-pagelinks-section' of https://github.com/Deven14125…
Deven14125 Mar 23, 2026
e2a6c51
Use text-gray-500 for separator
Deven14125 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/components/PageLinks/PageLinks.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,15 @@ import PropTypes from "prop-types";
const baseURL = "https://github.com/webpack/webpack.js.org/edit/main/";

function Separator() {
return <span className="mx-5 text-black font-bold dark:text-white">·</span>;
return (
<span className="mx-5 text-gray-500 font-semibold dark:text-gray-300">
·
</span>
);
}

const classes =
"text-gray-500 dark:text-gray-500 text-sm cursor-pointer font-sans hover:underline";
"text-gray-400 dark:text-gray-200 text-sm cursor-pointer font-sans hover:underline hover:text-gray-500 dark:hover:text-white transition-colors";
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text-gray-400 isn’t defined in this repo’s Tailwind theme (see tailwind.config.js colors: only gray 100/200/300/500/600/700/800/900). This class will not be generated, so the links may end up inheriting an unintended color in light mode. Use one of the configured grays (e.g., keep text-gray-500 or switch to text-gray-300/600) instead.

Suggested change
"text-gray-400 dark:text-gray-200 text-sm cursor-pointer font-sans hover:underline hover:text-gray-500 dark:hover:text-white transition-colors";
"text-gray-500 dark:text-gray-200 text-sm cursor-pointer font-sans hover:underline hover:text-gray-500 dark:hover:text-white transition-colors";

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep 500, it is better


function _handlePrintClick(event) {
event.preventDefault();
Expand All @@ -21,7 +25,7 @@ export default function PageLinks({ page = {} }) {
const editLink = page.edit || Url.resolve(baseURL, page.path);

return (
<div className="print:hidden mt-20">
<div className="print:hidden mt-8">
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mt-8 isn’t part of the configured Tailwind spacing scale in this repo (spacing is overridden to 0/5/10/20 in tailwind.config.js), so this margin class won’t be generated and the top spacing change won’t take effect. Use an existing spacing value (e.g., mt-10 or mt-5) to achieve the tightened layout.

Suggested change
<div className="print:hidden mt-8">
<div className="print:hidden mt-5">

Copilot uses AI. Check for mistakes.
<a className={classes} href={editLink}>
Edit this page
</a>
Expand Down
Loading