Skip to content

refactor(Container): migrate Container styles from SCSS to Tailwind CSS #8047 #8106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Deven14125 wants to merge 1 commit into from
Closed

refactor(Container): migrate Container styles from SCSS to Tailwind CSS #8047 #8106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/Container/Container.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import PropTypes from "prop-types";

import "./Container.scss";

export default function Container(props = {}) {
const { className = "" } = props;

return <div className={`container ${className}`}>{props.children}</div>;
return (
<div className={`w-full max-w-5xl mx-auto ${className}`}>
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the container CSS class from the Container root breaks existing SCSS selectors that rely on it (e.g. src/components/Splash/Splash.scss targets .splash__section .container for padding). Consider keeping a stable container class on this element for backward compatibility, or update the remaining SCSS/call sites that depend on .container to use Tailwind utilities instead.

Suggested change
<div className={`w-full max-w-5xl mx-auto ${className}`}>
<div className={`container w-full max-w-5xl mx-auto ${className}`}>

Copilot uses AI. Check for mistakes.
{props.children}
Comment on lines +7 to +8
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a template literal with ${className} causes an extra trailing space in the rendered class attribute when className is empty (visible in the updated snapshot). Consider joining class names conditionally (or trimming) to avoid unnecessary whitespace and snapshot churn.

Copilot uses AI. Check for mistakes.
</div>
);
}

Container.propTypes = {
Expand Down
9 changes: 0 additions & 9 deletions src/components/Container/Container.scss
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/components/Container/__snapshots__/Container.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`Container renders correctly with children and className 1`] = `
<div
class="container test-class"
class="w-full max-w-5xl mx-auto test-class"
>
<p>
Child content
Expand All @@ -12,7 +12,7 @@ exports[`Container renders correctly with children and className 1`] = `

exports[`Container renders correctly without className 1`] = `
<div
class="container "
class="w-full max-w-5xl mx-auto "
>
<span>
Simple child
Expand Down
2 changes: 1 addition & 1 deletion src/components/Footer/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const footerLinkClasses =

const Footer = () => (
<footer className="w-full flex-[0_0_auto] print:hidden">
<Container className="mx-auto max-w-[900px] px-5 pb-[30px] pt-[40px] text-center [&_a]:text-[#3b7eb5]">
<Container className="mx-auto max-w-5xl px-5 pb-[30px] pt-[40px] text-center [&_a]:text-[#3b7eb5]">
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Container now already applies max-w-5xl mx-auto, so adding mx-auto max-w-5xl again at the call site is redundant and makes it easier for these to drift out of sync later. Suggest dropping those two utilities from this className (keep the padding/typography utilities) and let Container own the width/centering.

Suggested change
<Container className="mx-auto max-w-5xl px-5 pb-[30px] pt-[40px] text-center [&_a]:text-[#3b7eb5]">
<Container className="px-5 pb-[30px] pt-[40px] text-center [&_a]:text-[#3b7eb5]">

Copilot uses AI. Check for mistakes.
<div className="mb-[24px] flex justify-center">
<a href="https://openjsf.org" target="_blank" rel="noopener noreferrer">
<img
Expand Down
Loading