-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
refactor(Print): migrate Print component styles from SCSS to Tailwind CSS #8047 #8105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import PropTypes from "prop-types"; | ||
| import "./Print.scss"; | ||
| import icon from "../../assets/icon-print.svg"; | ||
| import BarIcon from "../../styles/icons/vertical-bar.svg"; | ||
|
|
||
|
|
@@ -40,14 +39,20 @@ export default function Print(props) { | |
| fill="#175d96" | ||
| /> | ||
| <a | ||
| className="sidebar-item__title sidebar-link__print" | ||
| className="sidebar-item__title flex flex-nowrap items-center" | ||
| href={printUrl} | ||
| rel="nofollow noopener noreferrer" | ||
| title="Print" | ||
| target="_blank" | ||
| > | ||
| Print Section | ||
| <img src={icon} width={27} height={20} alt="Printer Icon" /> | ||
| <img | ||
| className="h-20 mr-0.5" | ||
| src={icon} | ||
| width={27} | ||
| height={20} | ||
| alt="Printer Icon" | ||
|
||
| /> | ||
| </a> | ||
| </div> | ||
| ); | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description mentions maintaining the existing class structure to avoid breaking global styles, but this change removes the
sidebar-link__printclass from the anchor. If backward compatibility is still a goal, consider keeping that class (even if styling moves to Tailwind), or update the PR description to reflect the change.