refactor(Cube): migrate from SCSS to Tailwind CSS - #8060
Closed
mr-baraiya wants to merge 6 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| key={i} | ||
| className="cube__face" | ||
| className={ | ||
| "absolute bg-transparent border-solid border-gray-400" + |
Member
There was a problem hiding this comment.
Please fix lint problems
Contributor
Author
|
Fixed the lint issues. |
| const variantClasses = isOuter | ||
| ? "border bg-blue-200/50 transition-[border-width] duration-200 delay-200" | ||
| : "border-2 bg-blue-400"; | ||
|
|
| {this._getFaces("outer")} | ||
| </figure> | ||
| <figure | ||
| className="cube__inner absolute -top-[2px] left-0 inline-block [transform-style:preserve-3d] transition-transform duration-1000" |
Member
There was a problem hiding this comment.
A lot of classes were removed which are already tailwind
| }} | ||
| > | ||
| <figure | ||
| className="cube__outer inline-block [transform-style:preserve-3d] transition-transform duration-1000" |
Member
There was a problem hiding this comment.
A lot of classes were removed which are already tailwind
| > | ||
| <span | ||
| ref={(ref) => (this.container = ref)} | ||
| className={`cube cube--${theme} relative block [transform-style:preserve-3d]`} |
Member
There was a problem hiding this comment.
Where transform-style:preserve-3d?
Member
|
Look at https://webpack-js-org-git-fork-mr-baraiya-feature-cube-tailwind-openjs.vercel.app/, result is broken |
Contributor
Author
|
Looks like this change has already been implemented and merged in another PR. Closing this PR to avoid duplication. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the Cube component from SCSS to Tailwind CSS as part of the effort described in #8047.
The goal is to gradually reduce SASS usage and move towards Tailwind-based styling.
In this PR:
Cube.scssfileWhat kind of change does this PR introduce?
refactor
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No