Skip to content

Remove unused parameters from vtab functions#7738

Merged
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-vtab-params
Apr 30, 2026
Merged

Remove unused parameters from vtab functions#7738
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-vtab-params

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Apr 30, 2026

No description provided.

@myrrc myrrc requested a review from 0ax1 April 30, 2026 16:06
@myrrc myrrc added the changelog/chore A trivial change label Apr 30, 2026
@myrrc myrrc force-pushed the myrrc/duckdb-vtab-params branch from 8361f36 to e5e8d4a Compare April 30, 2026 16:06
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 30, 2026

Merging this PR will degrade performance by 16.15%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 1192 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime runend[10M_i32_runlen_10] 197.2 µs 161.5 µs +22.1%
WallTime runend[10M_i32_runlen_1000] 138.2 µs 98.3 µs +40.63%
WallTime dynamic_dispatch_f32[10M] 165.9 µs 116.7 µs +42.11%
WallTime dynamic_dispatch_u32[10M] 167.9 µs 112.6 µs +49.09%
WallTime 10M_50%[5000000] 154.7 µs 184.5 µs -16.15%
Simulation bitwise_not_vortex_buffer_mut[128] 246.1 ns 275.3 ns -10.6%

Comparing myrrc/duckdb-vtab-params (a841631) with develop (573c995)

Open in CodSpeed

Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc force-pushed the myrrc/duckdb-vtab-params branch from e5e8d4a to a841631 Compare April 30, 2026 16:19
@myrrc myrrc enabled auto-merge (squash) April 30, 2026 16:21
@myrrc myrrc added the ext/duckdb Relates to the DuckDB integration label Apr 30, 2026
@myrrc myrrc merged commit deb7de0 into develop Apr 30, 2026
67 checks passed
@myrrc myrrc deleted the myrrc/duckdb-vtab-params branch April 30, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants