Skip to content

feat: teach Array<Struct> try_concat(&[Array<Struct>])#7632

Merged
danking merged 8 commits intodevelopfrom
dk/try-from-slice-array-struct
Apr 29, 2026
Merged

feat: teach Array<Struct> try_concat(&[Array<Struct>])#7632
danking merged 8 commits intodevelopfrom
dk/try-from-slice-array-struct

Conversation

@danking
Copy link
Copy Markdown
Contributor

@danking danking commented Apr 24, 2026

Look ma, no execution context!

Look ma, no execution context!

Signed-off-by: Daniel King <dan@spiraldb.com>
@danking danking marked this pull request as ready for review April 24, 2026 19:23
@danking danking requested review from connortsui20 and gatesn and removed request for gatesn April 24, 2026 19:23
@danking danking enabled auto-merge (squash) April 24, 2026 19:23
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 24, 2026

Merging this PR will degrade performance by 10.6%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 1195 untouched benchmarks
⏩ 33 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime for[10M_u32] 165.8 µs 115.2 µs +43.88%
WallTime mix[0%_in/100%_out] 277.5 µs 227.3 µs +22.07%
Simulation bitwise_not_vortex_buffer_mut[128] 246.1 ns 275.3 ns -10.6%

Comparing dk/try-from-slice-array-struct (86054db) with develop (e3a6b62)

Open in CodSpeed

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread vortex-array/src/arrays/struct_/array.rs Outdated
Comment thread vortex-array/src/validity.rs Outdated
Comment thread vortex-array/src/arrays/struct_/array.rs Outdated
danking added 3 commits April 24, 2026 15:44
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking danking added the changelog/feature A new feature label Apr 24, 2026
@danking danking requested a review from connortsui20 April 24, 2026 19:57
@danking danking changed the title feat: teach Array<Struct> try_from(&[Array<Struct>]) feat: teach Array<Struct> try_concat(&[Array<Struct>]) Apr 24, 2026
Comment thread vortex-array/src/arrays/chunked/vtable/canonical.rs Outdated
danking added 3 commits April 24, 2026 17:18
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Comment thread vortex-array/src/arrays/struct_/array.rs Outdated
Copy link
Copy Markdown
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove that one comment we can get this merged

Signed-off-by: Robert Kruszewski <github@robertk.io>
@danking danking merged commit 6fa3cae into develop Apr 29, 2026
66 checks passed
@danking danking deleted the dk/try-from-slice-array-struct branch April 29, 2026 15:33
robert3005 pushed a commit that referenced this pull request Apr 29, 2026
Look ma, no execution context!

Signed-off-by: Daniel King <dan@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants