feat: teach Array<Struct> try_concat(&[Array<Struct>])#7632
Conversation
Look ma, no execution context! Signed-off-by: Daniel King <dan@spiraldb.com>
Merging this PR will degrade performance by 10.6%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | for[10M_u32] |
165.8 µs | 115.2 µs | +43.88% |
| ⚡ | WallTime | mix[0%_in/100%_out] |
277.5 µs | 227.3 µs | +22.07% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
246.1 ns | 275.3 ns | -10.6% |
Comparing dk/try-from-slice-array-struct (86054db) with develop (e3a6b62)
Footnotes
-
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
robert3005
left a comment
There was a problem hiding this comment.
If you remove that one comment we can get this merged
Look ma, no execution context! Signed-off-by: Daniel King <dan@spiraldb.com>
Look ma, no execution context!