Test optimisation - #5
Merged
Merged
Conversation
XCTest calls setupWithError and tearDownWithError before each test method. This can be used to setup the sql client for each test. This centralises the test setup and cleanup. Ensuring that there is no race condition from a defer task, as well as shortening the logic for each test. Local clients have been constructed for testing connections and double connects. As this would not be compatible with the more global approach.
…onnection without credentials. Also added guard to skip deconstruction of nil connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimised and modularised some of the tests.
Used pre and post run methods to build and collapse the sqlclient.