crypto: add PublicKey::LoadFromPrivateKey and tests#1218
Open
crystarm wants to merge 1 commit intouserver-framework:developfrom
Open
crypto: add PublicKey::LoadFromPrivateKey and tests#1218crystarm wants to merge 1 commit intouserver-framework:developfrom
crystarm wants to merge 1 commit intouserver-framework:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refers to issue #665.
Added PublicKey::LoadFromPrivateKey(const PrivateKey&) to userver::crypto to derive a public key from an already loaded private key.
Implementation is minimal and additive: it validates input, uses OpenSSL to extract/load the public key, and throws crypto::KeyParseError on failures.
Test coverage added in universal/src/crypto/public_key_test.cpp:
Test keys for this are reused from existing crypto tests to keep fixtures consistent: RSA key from universal/src/crypto/signature_test.cpp, EC key from universal/src/crypto/public_key_test.cpp.