Skip to content

fix universal: use std::addressof in implementation of OptionalRef#1209

Closed
ddvamp wants to merge 1 commit intouserver-framework:developfrom
ddvamp:userver-patch-optional_ref
Closed

fix universal: use std::addressof in implementation of OptionalRef#1209
ddvamp wants to merge 1 commit intouserver-framework:developfrom
ddvamp:userver-patch-optional_ref

Conversation

@ddvamp
Copy link
Copy Markdown
Contributor

@ddvamp ddvamp commented Apr 27, 2026

Fixes #1208

Additionally, explicit operator!= has been removed.

@apolukhin
Copy link
Copy Markdown
Member

LGTM

@robot-magpie
Copy link
Copy Markdown

robot-magpie Bot commented Apr 28, 2026

Many thanks for the PR! @apolukhin is now importing your pull request into our internal upstream repository.

@robot-magpie
Copy link
Copy Markdown

robot-magpie Bot commented Apr 30, 2026

✅ This pull request is being closed because it has been successfully merged into our internal monorepository.
Your changes will be pushed to this repository soon. Thank you for your contribution!

@robot-magpie robot-magpie Bot closed this Apr 30, 2026
robot-piglet pushed a commit that referenced this pull request Apr 30, 2026
Fixes #1208
Tests: протестировано CI

Additionally, explicit `operator!=` has been removed.

---

Pull Request resolved: #1209

Co-authored-by: antoshkka <antoshkka@userver.tech>
Co-authored-by: antoshkka <antoshkka@userver.tech>
commit_hash:d6ee51c8c3e53d4f7a599d1bb6a8cebf3c0c7451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing std::addressof in OptionalRef

2 participants