Chore: Github PR related feature can extract URL from region as default PR/issue URL input#327
Chore: Github PR related feature can extract URL from region as default PR/issue URL input#327
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d1c9c2ae1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| review-source current-branch target-branch pr-title))) | ||
| (let* ((url-prompt (ai-code--pull-or-review-url-prompt review-mode)) | ||
| (target-url (ai-code-read-string url-prompt))) | ||
| (region-url (ai-code--extract-url-from-region)) |
There was a problem hiding this comment.
Compute the region URL before entering the minibuffer prompts; as written, ai-code--extract-url-from-region runs only after ai-code-pull-or-review-diff-file has already asked for review source and mode, and those interactive reads typically clear the active region, so use-region-p is nil and the URL default is not populated. In the common C-c a v flow (select URL in buffer, then choose source/mode), this makes the new feature effectively not work.
Useful? React with 👍 / 👎.
1 participant
No description provided.