Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Fix kex methods#150

Open
danhunsaker wants to merge 1 commit intotjibbevanderlaan:masterfrom
danhunsaker:fix-kex-methods
Open

Fix kex methods#150
danhunsaker wants to merge 1 commit intotjibbevanderlaan:masterfrom
danhunsaker:fix-kex-methods

Conversation

@danhunsaker
Copy link
Copy Markdown

Once a collection of four commits made on GitHub proper, and now a squashed commit of all four. The original commit comments are below.

  • Update sftp_thread.cc

Set our preferred keys to the default OpenSSH list. Because libssh2 is somewhat outdated in this category, it will only support diffie-hellman-group-exchange-sha256 for the moment, but this should help fix errors like #131. Still some more changes to make before this can be PR'd, but should be a lot closer. I hope.

  • Update English messages

Dutch is next!

  • Bijgewerkte Nederlandse berichten

Hoewel ik Google Translate heb gebruikt...

(For you English folk, that's an update to the Dutch messages, as promised in the previous commit.)

  • Update sftp_thread.h

Gotta declare the method before we can define it.

By these commits combined, we should have universal compatibility with OpenSSH servers - as soon as libssh2 adds the additional methods, that is. Anything more extensive may require switching to OpenSSH in the webports instead of libssh2.

* Update sftp_thread.cc

Set our preferred keys to the default OpenSSH list. Because libssh2 is somewhat outdated in this category, it will only support `diffie-hellman-group-exchange-sha256` for the moment, but this _should_ help fix errors like tjibbevanderlaan#131. Still some more changes to make before this can be PR'd, but should be a lot closer. I hope.

* Update English messages

Dutch is next!

* Bijgewerkte Nederlandse berichten

Hoewel ik Google Translate heb gebruikt...

(For you English folk, that's an update to the Dutch messages, as promised in the previous commit.)

* Update sftp_thread.h

Gotta declare the method before we can define it.
@stretch07
Copy link
Copy Markdown

#151

@danhunsaker
Copy link
Copy Markdown
Author

Yeah, I'd noticed. Still worth the effort to try.

At some point when i have more time, i plan to do a version that uses the newer (oddly) libssh instead of libssh2. Until then, though... Not a working fork yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants