fix: clear a stale commit selection after refresh - #91
Open
arumata wants to merge 1 commit into
Open
Conversation
When the selected commit is invalidated by a rebase/amend/merge and the graph refreshes, the commit disappears from commitStore but the selection was left pointing at it, so the bottom panel stayed open and empty with no way to dismiss it. Prune stale selections (single and multi) right after a log/full refresh so the panel closes cleanly (issue the0807#74).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the selected commit was invalidated by a rebase/amend/merge and the graph refreshed, the commit disappeared from the store but the selection stayed, so the bottom panel stayed open, empty, and without a close button. Stale selections (single and multi) are now pruned right after a log/full refresh.\n\nFixes #74.