Fix/markdown inline code entities - #87
Open
BenLocal wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix commit-message Markdown rendering so characters escaped by Marked are displayed normally instead of exposing HTML entities such as
<and".Examples:
`<if test="onlyHasVideo==true">`now displays literally.getEnumByCode("250")no longer displays asgetEnumByCode("250").Root Cause
Git Graph+ uses
marked.lexer()and renders the resulting token tree directly with Svelte.Marked escapes token text for insertion into its own HTML renderer. Because Git Graph+ renders those escaped values as Svelte text nodes instead, the encoded strings were
displayed verbatim.
Changes
Type of Change
Testing
npm run lintcd webview-ui && npm run checknpm run buildSecurity
The change does not introduce raw HTML rendering. It does not use
innerHTMLor Svelte{@html}.URL fields are not decoded and continue to use the existing HTTP(S)-only validation.