fix(upload): wrong progress callback parameter names in README#3406
Open
Zhoucheng133 wants to merge 2 commits intotauri-apps:v2from
Open
fix(upload): wrong progress callback parameter names in README#3406Zhoucheng133 wants to merge 2 commits intotauri-apps:v2from
Zhoucheng133 wants to merge 2 commits intotauri-apps:v2from
Conversation
Contributor
Package Changes Through bead3fcThere are 6 changes which include deep-link with patch, deep-link-js with patch, opener with patch, opener-js with patch, store with patch, store-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Zhoucheng133
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current documentation/examples for the download and upload functions use an incorrect destructuring pattern in the progress callback.
Currently, the examples suggest using ({ progress, total }), but according to the ProgressPayload interface in the source code, progress represents the chunk size (delta), while progressTotal represents the accumulated downloaded bytes.