feat(http): add status code 101, 103 for null body#2655
Merged
amrbashir merged 1 commit intotauri-apps:v2from Apr 30, 2025
Merged
feat(http): add status code 101, 103 for null body#2655amrbashir merged 1 commit intotauri-apps:v2from
amrbashir merged 1 commit intotauri-apps:v2from
Conversation
Contributor
Package Changes Through 23b327bThere are 7 changes which include single-instance with patch, fs with minor, fs-js with minor, http with patch, http-js with patch, opener with patch, opener-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Member
|
Ah didn't check chromium and just Firefox but iirc in Firefox you can't even construct Responses with 10X statuses so I didn't bother mentioning them in that pr (which was dumb) |
Contributor
Author
|
@FabianLars To improve performance, should we consider using an if statement instead? Benchmark |
Member
|
Hmm I don't think this difference matters much. |
amrbashir
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup for: #2647 and #2636
Description
For maximum compatibility I think it should follow fetch spec
Though Chromium only handles 101, 204, 205, 304
And Firefox only handles 204, 205, 304