fix(updater): download reuse check timeout#2572
Conversation
Package Changes Through 8841a78There are 10 changes which include autostart with minor, autostart-js with minor, http with patch, http-js with patch, deep-link with patch, deep-link-js with patch, fs with patch, fs-js with patch, updater with patch, updater-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| body: release.notes, | ||
| raw_json: raw_json.unwrap(), | ||
| timeout: self.timeout, | ||
| timeout: None, |
There was a problem hiding this comment.
This is the actual change 🙃
| // TODO: Align this with the result of `updater.check` to Result<Option<Metadata>> | ||
| // and remove `available` instead of handling this in the js side |
There was a problem hiding this comment.
I don't know if it's considered breaking if we change this from returning Result<Metadata> to Result<Option<Metadata>>, if not then I would like to do it before v3
There was a problem hiding this comment.
We can change it, if you want since we now require users to sync their rust and js versions
There was a problem hiding this comment.
That's nice, I'll do it later
* fix(updater): format `Update.date` to RFC 3339 * Messed up on argument in #2572 * Format * Update example * Avoid extra to_string * Deprecate `Update.available`
* fix(updater): download inherit timeout from check * Add change file
* fix(updater): format `Update.date` to RFC 3339 * Messed up on argument in tauri-apps#2572 * Format * Update example * Avoid extra to_string * Deprecate `Update.available`
2 participants
Fix #2372
Fix
timeoutpassed tocheckgets re-used bydownloadanddownloadAndinstallAlso did some other cleanups