Skip to content

Changing onkeydown description on all files except germany#303

Merged
sumn2u merged 1 commit intosumn2u:mainfrom
Danieljeffery695:changing-onkeydown-description
Aug 14, 2025
Merged

Changing onkeydown description on all files except germany#303
sumn2u merged 1 commit intosumn2u:mainfrom
Danieljeffery695:changing-onkeydown-description

Conversation

@Danieljeffery695
Copy link
Copy Markdown
Contributor

I made the description the same as Germany. I hope you don't mind.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
learn-javascript Ready Preview Comment Aug 14, 2025 6:28pm

@Danieljeffery695
Copy link
Copy Markdown
Contributor Author

Solving issue #292

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the description of the onkeydown event across multiple language files to match the German version. The change corrects the event description from "when the user press and then releases the key" to "when the user presses a key" to more accurately reflect the actual behavior of the onkeydown event.

  • Corrected the technical accuracy of the onkeydown event description
  • Updated translations across 6 different language files to maintain consistency

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tr/events.md Updated Turkish translation of onkeydown description
np/events.md Updated English and Nepali translations of onkeydown description
id/events.md Updated Indonesian translation of onkeydown description
fr/events.md Updated French translation of onkeydown description
es/events.md Updated Spanish translation of onkeydown description
en/events.md Updated English description of onkeydown event

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread np/events.md
| `onmouseover` | जब माउसको कर्सर तत्वमाथि आउँछ |
| `onmouseout` | जब माउसको कर्सर आउँछ तत्व छोड्छ |
| `onkeydown` | जब प्रयोगकर्ताले प्रेस गर्दछ र त्यसपछि कुञ्जी जारी गर्दछ |
| `onkeydown` | जब प्रयोगकर्ताले कुञ्जी थिच्छ |
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Nepali translation has inconsistent spacing. There are extra spaces before the closing pipe character that should be removed to match the formatting of other rows in the table.

Suggested change
| `onkeydown` | जब प्रयोगकर्ताले कुञ्जी थिच्छ |
| `onkeydown` | जब प्रयोगकर्ताले कुञ्जी थिच्छ |

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumn2u sumn2u merged commit 1b570ad into sumn2u:main Aug 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants