[6.x] Load installed starter kit config files into the running app - #15353
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Load installed starter kit config files into the running app#15353duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P8oP7YLEc2PqCXo9aCRdna
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where installing a starter kit that ships extra filesystem disks (like Peak's
faviconsdisk) would fail withDisk [favicons] does not have a configured driver.when creating the super user or updating the search index.This was happening because the starter kit's config files are copied into the app mid-install, but the running process still holds the config it loaded at boot. Saving the first user rebuilds the CP search index, which walks every asset container, and the new container's disk isn't in
filesystems.disksyet. The same thing happens whensearch:updateruns after install.This PR fixes it by loading each installed
config/*.phpfile into the config repository as it's copied, using the same dotted key Laravel derives at boot (eg.config/statamic/search.phpbecomesstatamic.search), so later install steps see the kit's config.Fixes #9884
Fixes #11972