[6.x] Pass validation replacements when storing and updating terms - #15352
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Pass validation replacements when storing and updating terms#15352duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G5YH82PMhzJd6UTWq19awp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a term blueprint using the
new \Statamic\Rules\UniqueTermValue({taxonomy}, {id}, {site})rule would always fail validation with "This value has already been taken" when saving an existing term.Statamic already enforces slug uniqueness itself in
TermsController, with the real taxonomy, term ID and site passed to the rule. However, you might want to use the rule yourself on a custom field, and the{taxonomy},{id}and{site}placeholders are the documented way to do that. Those placeholders are swapped in viawithReplacements(), whichTermsController@updateandstorenever called, so they all resolved tonull. With noexceptvalue, the rule matched the term being edited and failed.EntriesControllerandUsersControlleralready pass their own replacements.This PR fixes it by having
TermsController@updateandstorebuild their validators via$fields->validator()->withRules([...])->withReplacements([...]), passingid,taxonomyandsiteon update, andtaxonomyandsiteon store.Fixes #10078