[6.x] Fix named slots rendering empty inside nested partials - #15341
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Fix named slots rendering empty inside nested partials#15341duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
`checkPartialForNamedSlots` picked up non-paired `{{ slot:title }}` output tags inside a nested partial pair, reducing them to empty strings and overwriting the real slot content.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TDjs3WSZv7K4p2bX6e1DZ9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where named slots passed to a partial would render empty when that partial wrapped its body in another partial that uses
{{ slot }}.This was happening because
checkPartialForNamedSlotstreated any child node namedslotas a named slot definition. The non-paired{{ slot:title }}output tags inside the inner partial pair were picked up as definitions, reduced to empty strings (they have no children) and overwrote the real slot content in the context passed to the inner partial.This PR fixes it by only treating paired
{{ slot:name }}...{{ /slot:name }}tags as named slot definitions.Fixes #8437