[6.x] Fix durationForHumans deprecation warning and rounding#14541
Merged
jasonvarga merged 3 commits into6.xfrom Apr 23, 2026
Merged
[6.x] Fix durationForHumans deprecation warning and rounding#14541jasonvarga merged 3 commits into6.xfrom
jasonvarga merged 3 commits into6.xfrom
Conversation
jasonvarga
changed the title
Member
|
The deprecation warning was pointing out a bug that the precision was being lost. A time of |
jasonvarga
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where
Str::durationForHumans()emits "Implicit conversion from float to int loses precision" warnings on PHP 8.4 when called with a non-integer duration (e.g.36.92seconds from video/audio asset metadata).This was happening because the
%modulo operator was being used directly on the float input, which PHP 8.4 flags as a deprecation warning.This PR fixes it by casting the input to an integer at the top of the method.
Fixes #14538