-
Notifications
You must be signed in to change notification settings - Fork 363
fix(web): show empty-state messages in the browse file-tree panel #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
97470fe
b176c63
43f2949
15550f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { describe, expect, test, vi } from 'vitest'; | ||
| import { render, screen } from '@testing-library/react'; | ||
| import { SidebarProvider } from '@/components/ui/sidebar'; | ||
|
|
||
| // Stub the file-tree item component so the test only exercises the | ||
| // empty-state branch. The real component pulls in `usePathname` and | ||
| // a router context that's heavy to mock for an empty-state assertion. | ||
| vi.mock('@/app/(app)/browse/components/fileTreeItemComponent', () => ({ | ||
| FileTreeItemComponent: () => <li data-testid="file-tree-item" />, | ||
| })); | ||
|
|
||
| vi.mock('next/navigation', () => ({ | ||
| usePathname: () => '/browse/github.com/foo/bar@main/-/tree/src', | ||
| })); | ||
|
|
||
| vi.mock('@/hooks/use-mobile', () => ({ | ||
| useIsMobile: () => false, | ||
| })); | ||
|
|
||
| const { PureTreePreviewPanel } = await import('./pureTreePreviewPanel'); | ||
|
|
||
| const wrap = (ui: React.ReactNode) => ( | ||
| <SidebarProvider defaultOpen={true}> | ||
| <ul>{ui}</ul> | ||
| </SidebarProvider> | ||
| ); | ||
|
|
||
| describe('PureTreePreviewPanel empty state (issue #1530)', () => { | ||
| test('renders the "This directory is empty" message when the items array is empty', () => { | ||
| // The empty-state message is rendered inside the same | ||
| // ScrollArea as the items, so a real "directory" sub-path | ||
| // (path != '') still shows the path header above the panel | ||
| // and the "This directory is empty." copy below. The | ||
| // PureTree component doesn't know about the path; the caller | ||
| // decides whether to render the full panel (path != '') or | ||
| // the full-panel "This repository is empty" copy (path == ''). | ||
| render(wrap(<PureTreePreviewPanel items={[]} />)); | ||
| expect(screen.getByText('This directory is empty.')).toBeTruthy(); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,22 @@ export const TreePreviewPanelClient = ({ path, repoName, revisionName, repo }: T | |
| return <div>Error loading tree preview</div> | ||
| } | ||
|
|
||
| // Distinguish "the repository has no files" from "this sub-directory | ||
| // has no files" at the root path. The latter is handled inside | ||
| // `PureTreePreviewPanel` with a "This directory is empty." copy; | ||
| // the former is a stronger message and avoids rendering a path | ||
| // header for a non-existent root. See issue #1530. | ||
| if (folderContentsResponse.length === 0 && path === '') { | ||
| return ( | ||
| <div className="flex flex-col w-full min-h-full items-center justify-center gap-2 p-6 text-muted-foreground"> | ||
| <p className="text-sm font-medium">This repository is empty.</p> | ||
| <p className="text-xs"> | ||
| Once a commit lands on the default branch, its files will appear here. | ||
| </p> | ||
| </div> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Root empty state ignores active revisionMedium Severity The new root empty-state UI runs whenever Reviewed by Cursor Bugbot for commit 43f2949. Configure here. |
||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <> | ||
| <div className="flex flex-row py-1 px-2 items-center justify-between"> | ||
|
|
||


Uh oh!
There was an error while loading. Please reload this page.