Chad/2024/fixing import export and rebuilding types#1
Open
chadfurman wants to merge 5 commits intosketchpunklabs:mainfrom
Open
Chad/2024/fixing import export and rebuilding types#1chadfurman wants to merge 5 commits intosketchpunklabs:mainfrom
chadfurman wants to merge 5 commits intosketchpunklabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rebuilds the dist files and updates the package.json to allow importing from them. I also added "Gltf2Parser" as a named export so I can import with
import {Gltf2Parser} from "gltf2parser"-- I was having trouble with the default export and named export stuff being combined.I may be opening more PRs as well, depending on how my engagement shapes up with a new client. There's a lot of work to do around GLTF files on this project, if I actually win the contract. Right now, it's just prototyping stuff.
If I do win the contract, are you open to having a call about how I can collaborate with you on this project? Some things I will need to be able to do include splitting out materials and meshes into new GLTF files, centering meshes around origin (combining them all, finding their center, and then translating them), and a few more things.