[mod_sofia] Pass api_on_ prefix to switch_channel_api_on in sofia_glue_set_extra_headers - #3131
Open
jacky-w-j-li wants to merge 1 commit into
Open
Conversation
…e_set_extra_headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sofia_glue_set_extra_headers()built a singleexecute_on_<prefix>prefixvariable name and passed it to bothswitch_channel_execute_on()andswitch_channel_api_on().Both functions match channel variables by prefix (
strncasecmp(var, variable_prefix, strlen(variable_prefix))insrc/switch_channel.c), soswitch_channel_api_on()also matched theexecute_on_*variables and ran their values a second time as API commands. API commands have no session context, so scripts invoked this way saw a NULL session, and any logic in anexecute_on_sip_ph_prefix/execute_on_sip_rh_prefix(and other SIP header prefix) hook ran twice per SIP message.Build the
api_on_<prefix>prefixvariable name before callingswitch_channel_api_on(), matching the pattern already used forexecute_on_sip_extra_headers/api_on_sip_extra_headersjust below.Resolves: #3005