Skip to content

chore(deps): bump fastify from 5.8.3 to 5.8.5 in the npm-security group across 1 directory#3152

Open
dependabot[bot] wants to merge 2 commits intomainfrom
dependabot/npm_and_yarn/npm-security-dd6aeadc3f
Open

chore(deps): bump fastify from 5.8.3 to 5.8.5 in the npm-security group across 1 directory#3152
dependabot[bot] wants to merge 2 commits intomainfrom
dependabot/npm_and_yarn/npm-security-dd6aeadc3f

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 15, 2026

Bumps the npm-security group with 1 update in the / directory: fastify.

Updates fastify from 5.8.3 to 5.8.5

Release notes

Sourced from fastify's releases.

v5.8.5

⚠️ Security Release

This fixes CVE CVE-2026-33806 GHSA-247c-9743-5963.

What's Changed

New Contributors

Full Changelog: fastify/fastify@v5.8.4...v5.8.5

v5.8.4

Full Changelog: fastify/fastify@v5.8.3...v5.8.4

Commits
  • 3983cce Bumped v5.8.5
  • 3ce3ae6 Merge commit from fork
  • b06a196 docs(ecosystem): add @​pompelmi/fastify-plugin (#6610)
  • 909c5d5 chore: Bump actions/dependency-review-action from 4.8.3 to 4.9.0 (#6630)
  • 4db21a3 chore: Bump borp from 0.21.0 to 1.0.0 (#6633)
  • 0f4e544 chore: Bump markdownlint-cli2 from 0.21.0 to 0.22.0 (#6632)
  • 33a2fcd chore: Bump pnpm/action-setup from 4.2.0 to 5.0.0 (#6629)
  • fd35d82 ci: reduce cron schedules from daily/weekly to monthly (#6623)
  • 8dee9be fix: restore trustProxy function for number and string types, add null check ...
  • d457aed chore: upgrade to typescript v6.0.2 (#6605)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the npm-security group with 1 update in the / directory: [fastify](https://github.com/fastify/fastify).


Updates `fastify` from 5.8.3 to 5.8.5
- [Release notes](https://github.com/fastify/fastify/releases)
- [Commits](fastify/fastify@v5.8.3...v5.8.5)

---
updated-dependencies:
- dependency-name: fastify
  dependency-version: 5.8.5
  dependency-type: direct:production
  dependency-group: npm-security
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file full-ci javascript Pull requests that update Javascript code labels Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

size-limit report 📦

Path Size
react-on-rails/client bundled (gzip) 62.76 KB (0%)
react-on-rails/client bundled (gzip) (time) 62.76 KB (0%)
react-on-rails/client bundled (brotli) 53.86 KB (0%)
react-on-rails/client bundled (brotli) (time) 53.86 KB (0%)
react-on-rails-pro/client bundled (gzip) 63.71 KB (0%)
react-on-rails-pro/client bundled (gzip) (time) 63.71 KB (0%)
react-on-rails-pro/client bundled (brotli) 54.63 KB (0%)
react-on-rails-pro/client bundled (brotli) (time) 54.63 KB (0%)
registerServerComponent/client bundled (gzip) 127.53 KB (0%)
registerServerComponent/client bundled (gzip) (time) 127.53 KB (-0.01% 🔽)
registerServerComponent/client bundled (brotli) 61.7 KB (0%)
registerServerComponent/client bundled (brotli) (time) 61.7 KB (0%)
wrapServerComponentRenderer/client bundled (gzip) 122.02 KB (0%)
wrapServerComponentRenderer/client bundled (gzip) (time) 122.02 KB (0%)
wrapServerComponentRenderer/client bundled (brotli) 56.73 KB (0%)
wrapServerComponentRenderer/client bundled (brotli) (time) 56.73 KB (0%)

…rn/npm-security-dd6aeadc3f

* origin/main: (34 commits)
  fix(pro-dummy): make manual node-renderer validation reliable (#3200)
  [codex] Add Markdown Prettier CI check (#3242)
  Add /stress-test Claude Code command for adversarial QA (#3207)
  Document examples catalog and naming plan (#3191)
  test(dummy): enable StrictMode in OSS and Pro dummies (#3206)
  ci: exclude bot-blocking URLs from lychee link check (#3214)
  Remove stale Coveralls integration (#3204)
  docs: normalize external GitHub repo slugs in links and generators (#3198)
  docs: add Example Migrations page (#3125) (#3197)
  docs: warn about react_component helper collision with react-rails (#3143) (#3160)
  docs: legacy Webpacker and migration-fit guidance (#3138) (#3157)
  fix(specs): boot dummy specs without readline and drop redundant pnpm workspace (#3190)
  docs: add RSC migration success stories page (#1985) (#3162)
  Fix Bencher reporting permanently broken on pushes to main (#3148)
  docs: add example migrations guide (#3126)
  docs: remove defunct guavapass.com reference (#3199)
  chore: remove redundant --rsc-pro install generator flag (#3105)
  ci: warn (don't fail) on Bencher main regression (#3168)
  test: enable RSpec --profile to surface slowest package tests (#3176)
  fix(node-renderer): expose performance in VM context when supportModules (#3158)
  ...
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 4, 2026

Code Review: fastify 5.8.3 → 5.8.5 Security Bump

Verdict: Approve and merge. This is a clean, low-risk security patch with a clear upstream CVE.


What This PR Does

Bumps fastify from 5.8.3 to 5.8.5 in the react-on-rails-pro-node-renderer package to fix CVE-2026-33806 (GHSA-247c-9743-5963).

The vulnerability is in fastify's trustProxy handling: the fix restores correct behavior for trustProxy when configured as a number or string type, and adds a null check for socketAddr.


Assessment

Security impact is real but limited in this codebase.
worker.ts does not set trustProxy directly, but it spreads fastifyServerOptions from user config into the fastify instance, which means user-supplied trustProxy values of type number or string would have hit the bug. Patching is still the right call regardless.

Diff is correct and minimal.

  • package.json: minimum version constraint raised to ^5.8.5, ensuring the security fix is always required rather than just allowed.
  • pnpm-lock.yaml: integrity hash updated correctly for the new resolved version.

No breaking changes. 5.8.3 → 5.8.5 is a patch release; the Dependabot compatibility score supports no regressions.


One Follow-Up Item (not blocking)

The updated pnpm-lock.yaml surfaces a deprecation notice for a transitive dependency:

basic-ftp@5.2.0:
  deprecated: Security vulnerability fixed in 5.2.1, please upgrade

This is not introduced by this PR, but it is now visible. A separate Dependabot PR for whichever package pulls in basic-ftp would be worth tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file full-ci javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant