Skip to content

Commit 70479ad

Browse files
justin808claude
andcommitted
fix(pro-dummy): address PR #3200 review nits
Apply optional cleanups from CodeRabbit and claude[bot] review: - Replace `ndb` with `node --inspect` in `node-renderer:debug` so the script works without a global `ndb` install. Drop the duplicated hyphen-style `node-renderer-debug` script and update the OSS debugging doc to point at the colon-style name. - Use `parseInt(devServer.port, 10)` instead of `Number(devServer.port)` in both Pro dummy and ExecJS dummy webpack development configs to make the base-10 numeric-parse intent explicit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent eade3f4 commit 70479ad

4 files changed

Lines changed: 4 additions & 5 deletions

File tree

docs/oss/building-features/node-renderer/debugging.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Use this when you need full control over the renderer process — different flag
4242
1. If you want to attach a debugger instead, run:
4343
```bash
4444
cd react_on_rails_pro/spec/dummy
45-
pnpm run node-renderer-debug
45+
pnpm run node-renderer:debug
4646
```
4747
1. Reload the page that triggers the SSR issue and reproduce the problem.
4848
1. If you change Ruby code in loaded gems, restart the Rails server.

react_on_rails_pro/spec/dummy/config/webpack/development.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const developmentEnvOnly = (clientWebpackConfig, _serverWebpackConfig) => {
1313
overlay: {
1414
// bin/dev sets SHAKAPACKER_DEV_SERVER_PORT as a string, which Shakapacker
1515
// surfaces unchanged on devServer.port. The plugin schema requires a number.
16-
sockPort: Number(devServer.port),
16+
sockPort: parseInt(devServer.port, 10),
1717
},
1818
}),
1919
);

react_on_rails_pro/spec/dummy/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@
104104
"build:client": "RAILS_ENV=production NODE_ENV=production bin/shakapacker",
105105
"build:server": "RAILS_ENV=production NODE_ENV=production SERVER=true bin/shakapacker",
106106
"build:clean": "rm -rf public/webpack && rm -rf ssr-generated || true",
107-
"node-renderer-debug": "RENDERER_PORT=3800 ndb renderer/node-renderer.js",
108-
"node-renderer:debug": "RENDERER_PORT=3800 ndb renderer/node-renderer.js",
107+
"node-renderer:debug": "RENDERER_LOG_LEVEL=debug RENDERER_PORT=3800 node --inspect renderer/node-renderer.js",
109108
"node-renderer": "RENDERER_PORT=3800 node renderer/node-renderer.js",
110109
"node-renderer:fresh": "pnpm --filter react-on-rails-pro-node-renderer run build && RENDERER_LOG_LEVEL=debug RENDERER_PORT=3800 node --inspect renderer/node-renderer.js",
111110
"node-renderer:build-watch": "pnpm --filter react-on-rails-pro-node-renderer run build-watch"

react_on_rails_pro/spec/execjs-compatible-dummy/config/webpack/development.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const developmentEnvOnly = (clientWebpackConfig, _serverWebpackConfig) => {
1818
overlay: {
1919
// bin/dev sets SHAKAPACKER_DEV_SERVER_PORT as a string, which Shakapacker
2020
// surfaces unchanged on devServer.port. The plugin schema requires a number.
21-
sockPort: Number(devServer.port),
21+
sockPort: parseInt(devServer.port, 10),
2222
},
2323
}),
2424
);

0 commit comments

Comments
 (0)