fix(pro-dummy): address PR #3200 review feedback

Applies reviewer suggestions against the manual validation workflow so the
guide matches the actual supported Ruby range, the freshness check is
accurate, and the convenience scripts mirror the Procfile invocation.

- docs: broaden Ruby guidance (3.3.x baseline, 3.4.8 verified, 3.5+ via
  explicit ostruct/logger/benchmark gems); move `mise shell ruby@3.3.7`
  under an "Optional fallback" block so 3.4.x users see the right path.
- docs: replace unreliable directory-level `ls -la` mtime comparison with
  a per-file `find ... -newer ...` check, and update the report template
  to match.
- Procfile.dev: note foreman/overmind concurrency caveat when uncommenting
  `node-renderer-build` (wait for first build-watch compile on first run).
- package.json: add `node-renderer:debug` colon alias for naming
  consistency; align `node-renderer:fresh` flags with the Procfile.dev
  entry (`RENDERER_LOG_LEVEL=debug`, `--inspect`).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: justin808

.claude/docs/validating-node-renderer-changes.md

@@ -21,15 +21,19 @@ If your PR touches **any** of these, run through the checklist below:
 
 ## Pre-flight: Toolchain
 
-The Pro dummy app requires Ruby 3.3.x. If you are on a newer Ruby (3.5+), the dummy's
-Gemfile already pulls in `ostruct`, `logger`, and `benchmark` as explicit gems to silence
-warnings, but you may still hit unrelated incompatibilities. When in doubt, switch to the
-documented Ruby version:
+Ruby 3.3.x is the documented baseline for the Pro dummy app, and this workflow
+has also been verified on Ruby 3.4.8. On Ruby 3.5+, the dummy's Gemfile pulls in
+`ostruct`, `logger`, and `benchmark` as explicit gems for stdlib compatibility.
+If a newer Ruby hits unrelated incompatibilities, fall back to the documented
+Ruby version.
 
 ```bash
-mise use ruby@3.3.7  # or rbenv/asdf equivalent
 cd react_on_rails_pro/spec/dummy
 bundle install
+
+# Optional fallback if your local Ruby fails:
+mise shell ruby@3.3.7  # or rbenv/asdf equivalent
+bundle install
 ```
 
 ## Step 1: Rebuild the Renderer Package
@@ -97,9 +101,10 @@ For each route:
 
 It is easy to validate stale lib output without realizing it. Confirm:
 
-- [ ] `lib/` mtime is newer than the `src/` file you changed (compare
-      `ls -la packages/react-on-rails-pro-node-renderer/lib/` against
-      `ls -la packages/react-on-rails-pro-node-renderer/src/`)
+- [ ] The built `lib/` file corresponding to your edit is newer than the `src/`
+      file you changed. Compare the specific files with `stat` or use a
+      per-file freshness check, for example:
+      `find packages/react-on-rails-pro-node-renderer/lib -newer packages/react-on-rails-pro-node-renderer/src/<changed-file>.ts | head`
 - [ ] If you used watch mode, you saw a rebuild line in the watcher output after your
       most recent edit
 - [ ] Restart the `node-renderer` Procfile process after the rebuild — `node` does not
@@ -111,7 +116,7 @@ It is easy to validate stale lib output without realizing it. Confirm:
 ## Node Renderer Validation
 
 - [x] Rebuilt `react-on-rails-pro-node-renderer` package
-- [x] Verified `lib/` mtime newer than `src/` after edit
+- [x] Verified the rebuilt `lib/` file is newer than the changed `src/` file
 - [x] `bin/dev` starts cleanly
 - [x] `/stream_native_metadata` renders without errors
 - [x] `/hybrid_metadata_streaming` renders without errors

react_on_rails_pro/spec/dummy/Procfile.dev

@@ -15,5 +15,7 @@ rails-rsc-assets: HMR=true RSC_BUNDLE_ONLY=true bin/shakapacker --watch
 # When validating source changes under `packages/react-on-rails-pro-node-renderer/src/**`,
 # either rebuild once (`pnpm --filter react-on-rails-pro-node-renderer run build`) or
 # uncomment the `node-renderer-build` line below to watch and rebuild on every save.
+# Foreman/overmind starts processes concurrently, so on first use wait for the initial
+# build-watch compile or restart `node-renderer` before trusting renderer output.
 # node-renderer-build: pnpm --filter react-on-rails-pro-node-renderer run build-watch
 node-renderer: RENDERER_LOG_LEVEL=debug RENDERER_PORT=3800 node --inspect renderer/node-renderer.js

react_on_rails_pro/spec/dummy/package.json

@@ -105,8 +105,9 @@
     "build:server": "RAILS_ENV=production NODE_ENV=production SERVER=true bin/shakapacker",
     "build:clean": "rm -rf public/webpack && rm -rf ssr-generated || true",
     "node-renderer-debug": "RENDERER_PORT=3800 ndb renderer/node-renderer.js",
+    "node-renderer:debug": "RENDERER_PORT=3800 ndb renderer/node-renderer.js",
     "node-renderer": "RENDERER_PORT=3800 node renderer/node-renderer.js",
-    "node-renderer:fresh": "pnpm --filter react-on-rails-pro-node-renderer run build && RENDERER_PORT=3800 node renderer/node-renderer.js",
+    "node-renderer:fresh": "pnpm --filter react-on-rails-pro-node-renderer run build && RENDERER_LOG_LEVEL=debug RENDERER_PORT=3800 node --inspect renderer/node-renderer.js",
     "node-renderer:build-watch": "pnpm --filter react-on-rails-pro-node-renderer run build-watch"
   },
   "license": "UNLICENSED",