Open
Conversation
… TitleLink to avoid render tree
…te from LinkableHeading to TitleLink
🦋 Changeset detectedLatest commit: 5f01f43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| {section.label ? ( | ||
| <Heading | ||
| level="3" | ||
| aria-describedby={ |
Contributor
There was a problem hiding this comment.
As above, i dont believe this is passed through (TS doesnt validate aria- so no errors, but also it doesnt apply).
We could do with a lap of whitelisting and opening some aria props i think.
Contributor
Author
There was a problem hiding this comment.
This is a little hairy with a programatic aria-describedby as part of TitleLink. I'll push up a solution and you can give me your thoughts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated
DocDetailsandSideNavigationto use new<CategoryHeading>component.This kicked off a minor cascade of changes in support, primary of which is the creation of a new
<TitleLink>component - a hash-linked anchor with an optional copyable prop that enables copying the URL to clipboard.Other changes are minor refactors, elevation of
<CategoryHeading>intodocs-ui, etc.