fix(sync): (Codex) OAuth refresh token race#1392
Open
cyfung1031 wants to merge 2 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在 auth.ts 加入以 NetDiskType 为 key 的 refreshTokenPromises。同一个云端 provider 的多个并行 AuthVerify() 如果同时遇到过期或失效 token，现在会共用同一个 refresh promise；第一个请求负责刷新并写回新 token，其余请求等待同一结果，避免用已被旋转失效的 refresh token 重复刷新。
同时在 auth.test.ts 加了回归测试：三个并行 AuthVerify("onedrive") 只会触发一次 fetch refresh，并全部拿到新的 access token。