Skip to content

CLDSRV-992: Build the uploadPartCopy fixtures once per suite, not per test - #6280

Draft
anurag4DSB wants to merge 1 commit into
hotfix/9.2.36from
improvement/CLDSRV-992-9.2.36-uploadpartcopy-fixture-per-suite
Draft

CLDSRV-992: Build the uploadPartCopy fixtures once per suite, not per test#6280
anurag4DSB wants to merge 1 commit into
hotfix/9.2.36from
improvement/CLDSRV-992-9.2.36-uploadpartcopy-fixture-per-suite

Conversation

@anurag4DSB

@anurag4DSB anurag4DSB commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Intent: why does this change exist?

NEW FIX. Both uploadPartCopy describes in the PartNumber tests rebuild a ~200 MB MPU fixture in a beforeEach, though all four of their tests only issue a GetObject. The redundant second build is what exceeds the 40 s mocha timeout. Clears the timeout half of CLDSRV-992 row F8 (run 33647777908).

System impact: what's affected, including downstream?

One functional test file, setup and teardown only. No product code, no assertions touched. development/9.3 needs the same change and has #6281.

Preserved behavior: what explicitly stays the same?

The fixture is identical and both tests read exactly what they read before. No timeout raised, no retry added, nothing skipped. That row's separate ServiceUnavailable on "part 8 when ordered MPU" is a different transient and is not addressed here.

Intended change: what's different after this PR?

Setup moves to before and cleanup to after, so each describe builds its fixture once. The enclosing describe already owns the bucket in its own before/after, so the fixture safely outlives the tests.

Verification: how do we know this worked, or how would we know if it didn't?

The cost is arithmetic from the fixture itself: a serial 10x5 MB completeMPU, a 50 MB UploadPartCopy, a 50 MB UploadPart, then a further 5 MB part and second 50 MB copy. Both tests are pure GetObject calls, so the second build did no work they depended on. s3c-ft-tests-v0 stressed 10x on this branch.

… test

Both `uploadPartCopy` describes in the PartNumber tests rebuild a large MPU
fixture in a beforeEach, although all four of their tests only issue a
GetObject. Each rebuild moves roughly 200 MB: completeMPU uploads ten 5 MB
parts one at a time with async.eachSeries, createMPUAndPutTwoParts copies that
50 MB object and then puts a 50 MB body, and the overwrite variant adds a 5 MB
part and a second 50 MB UploadPartCopy. Doing that twice per describe, once for
each read-only test, is what pushes the hook past the 40 s mocha timeout on the
s3c backend.

Move the setup to `before` and the DeleteObject cleanup to `after`. The fixture
is identical for both tests in each describe, and the enclosing describe creates
the bucket in its own `before` and drops it in `after`, so the fixture safely
outlives the individual tests. Halves the data moved by these two describes and
removes the redundant rebuild, rather than raising the timeout.

Clears the timeout half of CLDSRV-992 row F8 (run 33647777908): the "before
each" hook for "should retrieve a part that overwrote another part originally
copied from an MPU". The same row's ServiceUnavailable on "should get the body
of part 8 when ordered MPU" is a separate transient and is not addressed here.

Issue: CLDSRV-992
@bert-e

bert-e commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Hello anurag4dsb,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/bypass_source_branch_lineage Bypass the cross-branch contamination check
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-992 contains:

  • None

Considering where you are trying to merge, I expected to find at least:

  • 9.2.36.1

Please check the Fix Version/s of CLDSRV-992, or the target
branch of this pull request.

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.37%. Comparing base (ce53804) to head (8245437).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           hotfix/9.2.36    #6280   +/-   ##
==============================================
  Coverage          84.37%   84.37%           
==============================================
  Files                204      204           
  Lines              13162    13162           
==============================================
  Hits               11106    11106           
  Misses              2056     2056           
Flag Coverage Δ
unit 69.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anurag4DSB
anurag4DSB marked this pull request as ready for review September 8, 2026 11:02
@anurag4DSB
anurag4DSB force-pushed the improvement/CLDSRV-992-9.2.36-uploadpartcopy-fixture-per-suite branch from 8245437 to 4bbb2af Compare September 8, 2026 11:02
@anurag4DSB
anurag4DSB marked this pull request as draft September 8, 2026 11:15
@anurag4DSB

Copy link
Copy Markdown
Contributor Author

Moving back to draft along with #6281 — same reasoning. The change was justified as fixture cost, but the CI logs show the fixture is not slow (the same build succeeds three or four times per run then stalls once), so this halves exposure to an unexplained stall while giving up per-test independence.

These s3c jobs capture no cloudserver log, which is why the stall cannot be diagnosed today. #6283 adds that capture first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants