Skip to content

Fix GCS ':' encoding for proxied multipart complete and abort #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthiasL-scality merged 2 commits into from
Jul 17, 2026
Merged

Fix GCS ':' encoding for proxied multipart complete and abort #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6426f92
Fix GCS ':' encoding for proxied multipart complete and abort
matthiasL-scality Jul 17, 2026
73e8b55
Fix: GCS excludes uploadId/partNumber from canonical resource
matthiasL-scality Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 45 additions & 12 deletions lua/compute_aws_s3_signature.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,21 @@ elseif signature_mode == "MULTIPART_UPLOAD_PART" then
if not part_number or part_number == "" or not upload_id or upload_id == "" then
return ngx.exit(ngx.HTTP_BAD_REQUEST)
end
compute_S3_signature_with_resource(
"x-amz-date:" .. ngx.var.x_amz_date,
"/" .. ngx.var.aws_tgt_bucket .. "/" .. ngx.var.encoded_key .. "?partNumber=" .. part_number .. "&uploadId=" .. upload_id
)
-- GCS does not include partNumber/uploadId in the canonical resource and
-- normalises ':' to '%3A' in the key — same quirks as for presigned part PUTs.
-- Standard S3-compatible backends include subresources and keep literal ':'.
if (os.getenv('ENDPOINT_URL') or ''):find('googleapis', 1, true) then
ngx.var.encoded_key = ngx.var.encoded_key:gsub(':', '%%3A')
compute_S3_signature_with_resource(
"x-amz-date:" .. ngx.var.x_amz_date,
"/" .. ngx.var.aws_tgt_bucket .. "/" .. ngx.var.encoded_key
)
else
compute_S3_signature_with_resource(
"x-amz-date:" .. ngx.var.x_amz_date,
"/" .. ngx.var.aws_tgt_bucket .. "/" .. ngx.var.encoded_key .. "?partNumber=" .. part_number .. "&uploadId=" .. upload_id
)
end

elseif signature_mode == "MULTIPART_COMPLETE" then

Expand All @@ -309,10 +320,21 @@ elseif signature_mode == "MULTIPART_COMPLETE" then
if not upload_id or upload_id == "" then
return ngx.exit(ngx.HTTP_BAD_REQUEST)
end
compute_S3_signature_with_resource(
"x-amz-date:" .. ngx.var.x_amz_date,
"/" .. ngx.var.aws_tgt_bucket .. "/" .. ngx.var.encoded_key .. "?uploadId=" .. upload_id
)
-- GCS does not include uploadId in the canonical resource and normalises
-- ':' to '%3A' in the key. Standard S3-compatible backends include the
-- subresource and keep literal ':'.
if (os.getenv('ENDPOINT_URL') or ''):find('googleapis', 1, true) then
ngx.var.encoded_key = ngx.var.encoded_key:gsub(':', '%%3A')
compute_S3_signature_with_resource(
"x-amz-date:" .. ngx.var.x_amz_date,
"/" .. ngx.var.aws_tgt_bucket .. "/" .. ngx.var.encoded_key
)
else
compute_S3_signature_with_resource(
"x-amz-date:" .. ngx.var.x_amz_date,
"/" .. ngx.var.aws_tgt_bucket .. "/" .. ngx.var.encoded_key .. "?uploadId=" .. upload_id
)
end

elseif signature_mode == "MULTIPART_ABORT" then

Expand All @@ -327,10 +349,21 @@ elseif signature_mode == "MULTIPART_ABORT" then
if not upload_id or upload_id == "" then
return ngx.exit(ngx.HTTP_BAD_REQUEST)
end
compute_S3_signature_with_resource(
"x-amz-date:" .. ngx.var.x_amz_date,
"/" .. ngx.var.aws_tgt_bucket .. "/" .. ngx.var.encoded_key .. "?uploadId=" .. upload_id
)
-- GCS does not include uploadId in the canonical resource and normalises
-- ':' to '%3A' in the key. Standard S3-compatible backends include the
-- subresource and keep literal ':'.
if (os.getenv('ENDPOINT_URL') or ''):find('googleapis', 1, true) then
ngx.var.encoded_key = ngx.var.encoded_key:gsub(':', '%%3A')
compute_S3_signature_with_resource(
"x-amz-date:" .. ngx.var.x_amz_date,
"/" .. ngx.var.aws_tgt_bucket .. "/" .. ngx.var.encoded_key
)
else
compute_S3_signature_with_resource(
"x-amz-date:" .. ngx.var.x_amz_date,
"/" .. ngx.var.aws_tgt_bucket .. "/" .. ngx.var.encoded_key .. "?uploadId=" .. upload_id
)
end

elseif signature_mode == "PRESIGN_PUT" then

Expand Down
Loading