Skip to content

fix(cli): honor editor_files opt-outs during init and update - #2226

Merged
RaghavChamadiya merged 2 commits into
repowise-dev:mainfrom
z2Ace0107:fix/2137-editor-file-optout
Sep 14, 2026
Merged

fix(cli): honor editor_files opt-outs during init and update#2226
RaghavChamadiya merged 2 commits into
repowise-dev:mainfrom
z2Ace0107:fix/2137-editor-file-optout

Conversation

@z2Ace0107

Copy link
Copy Markdown
Contributor

Summary

Fix editor_files.<project_file_id>: false being ignored during editor project-file setup.

  • Resolve persisted opt-outs once in the setup layer using registered agent target descriptors.
  • Honor vscode_mcp: false during both init and update.
  • Keep explicit per-run project-file overrides stronger than persisted opt-outs.
  • Keep Codex MCP and hooks registration independent from the agents_md opt-out.

The separate project-file purge behavior mentioned in the issue remains out of scope.

Validation

  • uv run pytest tests/unit/cli/test_editor_setup.py tests/unit/cli/test_vscode_setup.py tests/unit/cli/test_agent_target_baseline.py -q (78 passed)
  • uv run ruff check packages/cli/src/repowise/cli/editor_setup.py packages/cli/src/repowise/cli/editor_integrations/codex.py tests/unit/cli/test_editor_setup.py (passed)
  • uv run ruff format --check packages/cli/src/repowise/cli/editor_setup.py packages/cli/src/repowise/cli/editor_integrations/codex.py tests/unit/cli/test_editor_setup.py (passed)
  • uv run mypy packages/cli/src/repowise/cli/editor_setup.py packages/cli/src/repowise/cli/editor_integrations/codex.py (passed)
  • npm run lint (passed; existing warning in an untouched UI file)
  • npm run type-check (passed)

Fixes #2137

@RaghavChamadiya RaghavChamadiya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @z2Ace0107. Resolving explicit editor-file opt-outs into disabled_project_files preserves default behavior and explicit overrides while keeping the Codex MCP and hook toggles separate from AGENTS.md generation. The regression tests cover those contracts. Approved.

@RaghavChamadiya
RaghavChamadiya merged commit 971562f into repowise-dev:main Sep 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update/init rewrite .vscode/mcp.json + .vscode/extensions.json unconditionally; editor_files: {vscode_mcp: false} is never read

2 participants