fix(ui): clamp generation progress percentages - #2224
Merged
RaghavChamadiya merged 1 commit intoSep 14, 2026
Merged
Conversation
Keep generation labels and progress accessibility values within 0-100 even when job totals are inconsistent. Harden the shared progress primitive against invalid finite and non-finite inputs. Closes repowise-dev#2176
akkupratap323
requested review from
RaghavChamadiya and
swati510
as code owners
September 11, 2026 15:45
Contributor
Author
|
@RaghavChamadiya The assigned fix is ready. Could you please review this PR and assign it if appropriate? Thank you. |
RaghavChamadiya
approved these changes
Sep 14, 2026
RaghavChamadiya
left a comment
Member
There was a problem hiding this comment.
Thanks @akkupratap323. Clamping at both the generation boundary and the shared progress component covers raw percentages as well as finite derived values, while preserving indeterminate handling for missing and non-finite input. The regression coverage matches those cases. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
GenerationProgresscould display percentages above 100% when a job reported more completed pages than its stale total. For241 / 5, the UI rendered4820%, passed an invalid value to Radix, droppedaria-valuenow, and generated malformed transform CSS.This change clamps the displayed generation percentage to
0-100. It also hardens the sharedProgressprimitive so all finite inputs are bounded before reaching Radix or the indicator transform; non-finite inputs retain the indeterminate state.Validation
Closes #2176