Fix unused_import for re-exported modules - #6900
Draft
catlover-bot wants to merge 1 commit into
Draft
Conversation
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
unused_importincorrectly removing an umbrella import when symbols areused through one of that module's
@_exportedimports.SourceKit reports the referenced symbol's defining module, not the umbrella
module imported by the source file. The rule now resolves exported imports
with
swift-api-digesterbefore classifying an umbrella import as unused.Implementation
Importnodes markedExported.allowed_transitive_importsandrequire_explicit_imports.Regression coverage
Foundation -> CoreFoundationworkaround from theexisting
CGFloatexample.failure retry, and separate compiler contexts.
A -> @_exported import Bpackage and a plain-import control.Validation
UnusedImportRuleGeneratedTests: passedOpened as a draft for cross-platform CI validation of the API-digester
integration.
Closes #5528