-
Notifications
You must be signed in to change notification settings - Fork 201
Fix #858: tell buildx which platform to build for #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9bdf01d
Fix #858: tell buildx which platform to build for
mhucka 399dd50
Error still persists, so trying another approach
mhucka 9efe1cd
Remove outputs
mhucka 81a50d0
Name the first build stage something other than "qsim"
mhucka 08288ca
Try clearing the docker buildx cache
mhucka cbaa2b8
Fix syntax of prune command
mhucka fba8268
Prune did nothing; try building with --no-cache
mhucka 94cd0d2
Rewrite docker & docker-compose files
mhucka bfed264
Fix casing
mhucka c8156d4
Try another variation
mhucka 1786db8
Try another variation
mhucka 21ef932
Fix wrong image name
mhucka e9af982
Use less ambiguous names for the services
mhucka b7c89c9
More tweaks
mhucka 8b7f394
Try one more
mhucka 18d9ea4
Revert & explain what's going on
mhucka c46833f
Fix command
mhucka 74646ce
Pin GHA to hash
mhucka 4f1366c
Try without the docker action
mhucka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,26 @@ | ||
| services: | ||
| qsim: | ||
| image: qsim | ||
| container_name: qsim | ||
| qsim-base-image: | ||
| image: qsim-base | ||
| platform: linux/amd64 | ||
| build: | ||
| context: ./ | ||
| dockerfile: Dockerfile | ||
| qsim-cxx-tests: | ||
| target: qsim-base | ||
|
|
||
| qsim-cxx-tests-image: | ||
| image: qsim-cxx-tests | ||
| container_name: qsim-cxx-tests | ||
| build: | ||
| context: ./ | ||
| dockerfile: tests/Dockerfile | ||
| target: qsim-cxx-tests | ||
| depends_on: | ||
| - qsim | ||
| qsim-py-tests: | ||
| - qsim-base-image | ||
|
|
||
| qsim-py-tests-image: | ||
| image: qsim-py-tests | ||
| container_name: qsim-py-tests | ||
| build: | ||
| context: ./ | ||
| dockerfile: pybind_interface/Dockerfile | ||
| target: qsim-py-tests | ||
| depends_on: | ||
| - qsim | ||
| - qsim-base-image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # Base OS | ||
| FROM qsim | ||
| FROM qsim-base AS qsim-cxx-tests | ||
|
|
||
| # Copy relevant files | ||
| COPY ./tests/ /qsim/tests/ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.