Fix #846: multip. result converted to larger type#849
Merged
Conversation
CodeQL scans flagged the construct ➀ below on line 53 in `lib/matrix.h` because the multiplication result may overflow 'unsigned int' before it is converted to 'size_type'.
```C++
template <typename fp_type>
inline void MatrixIdentity(unsigned n, Matrix<fp_type>& m) {
m.resize(2 * n * n); ➀
```
The warning is:
> This rule finds code that converts the result of an integer multiplication to a larger type. Since the conversion applies after the multiplication, arithmetic overflow may still occur.
dstrain115
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL scans flagged the construct ➀ below on line 53 in
lib/matrix.hbecause the multiplication result may overflow 'unsigned int' before it is converted to 'size_type'.The warning is: