Add error path test for invalid number of targets to add_op_to_circuit#1039
Closed
mhucka wants to merge 3 commits intoquantumlib:mainfrom
Closed
Conversation
…get qubits in add_op_to_circuit Addresses a testing gap in `qsimcirq/qsim_circuit.py` where the `NotImplementedError` for controlled gates with more than 4 target qubits was not explicitly tested. 🎯 **What:** The testing gap addressed - Added `test_add_op_to_circuit_too_many_targets` to `qsimcirq_tests/qsimcirq_test.py`. 📊 **Coverage:** What scenarios are now tested - Controlled gates with more than 4 target qubits (specifically 5 targets) are now verified to raise `NotImplementedError` with the correct error message. ✨ **Result:** The improvement in test coverage - Increased reliability of the `add_op_to_circuit` function by covering a previously untested error path.
…-limit-16945383875852359583
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new test case, test_add_op_to_circuit_too_many_targets, to verify that controlled gates with more than four target qubits correctly raise a NotImplementedError. However, the feedback indicates that this test is redundant because the error path is already validated in test_control_limits. Furthermore, the test is likely broken due to an incorrect reference to add_op_to_circuit, which would result in an AttributeError.
Comment on lines
+882
to
+894
| def test_add_op_to_circuit_too_many_targets(): | ||
| # qsim supports up to 4 target qubits for controlled gates. | ||
| qubits = cirq.LineQubit.range(6) | ||
| # A gate with 5 targets and 1 control. | ||
| big_gate = cirq.MatrixGate(np.eye(32)).on(*qubits[1:]).controlled_by(qubits[0]) | ||
|
|
||
| qsim_circuit = qsimcirq.qsim.Circuit() | ||
| qubit_to_index = {q: i for i, q in enumerate(qubits)} | ||
|
|
||
| with pytest.raises( | ||
| NotImplementedError, match="Received control gate on 5 target qubits" | ||
| ): | ||
| qsimcirq.add_op_to_circuit(big_gate, 0, qubit_to_index, qsim_circuit) |
Contributor
There was a problem hiding this comment.
This new test case is redundant and likely contains a bug that will prevent it from running.
- Redundancy: The
NotImplementedErrorfor controlled gates with more than 4 target qubits is already explicitly verified intest_control_limits(lines 876-879), which uses the publicsimulateAPI to trigger the same code path and matches the same error message. - Likely AttributeError:
add_op_to_circuitis defined in theqsim_circuitmodule. Unless it is explicitly exported inqsimcirq/__init__.py, the call toqsimcirq.add_op_to_circuitwill fail. Based on the usage inqsim_simulator.py(line 22), it should likely be accessed viaqsimcirq.qsim_circuit.add_op_to_circuit.
Since the error path is already covered by an existing integration test and the unit test implementation is likely broken, it is recommended to remove this redundant test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a testing gap in
qsimcirq/qsim_circuit.pywhere theNotImplementedErrorfor controlled gates with more than 4 target qubits was not explicitly tested.