Skip to content

Change .editorconfig to use indent = 8 for Makefiles #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhucka wants to merge 4 commits into from
Closed

Change .editorconfig to use indent = 8 for Makefiles #1038

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48a537c
Don't use indent size = 4 for Makefiles
mhucka Apr 5, 2026
b7985f0
Explicitly set tab_width = 8
mhucka Apr 5, 2026
85a8042
Merge branch 'main' into undo-indent-size-for-makefiles
mhucka Apr 7, 2026
2d065b5
Only set tab_width for makefiles
mhucka Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ root = true
charset = utf-8
indent_style = space
insert_final_newline = true
max_line_length = 80
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description states that an explicit global default for tab_width = 8 is being set, but this setting is missing from the [*] section. This should be added to ensure consistent tab rendering across all file types as intended.

max_line_length = 80
tab_width = 8
References
  1. Consistency: Be consistent with naming convention, style, and other patterns in the code base. (link)

spelling_language = en-US
tab_width = 8
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding tab_width = 8 to the global [*] section can lead to inconsistent indentation across the project. In many editors, tab_width is used as a fallback for indent_size when the latter is not specified, even for indent_style = space. This would cause any file types not explicitly defined in this file to default to an 8-space indentation, which is inconsistent with the 2 or 4 spaces used throughout the rest of the project. To maintain Consistency (Repository Style Guide, line 14), it is better to specify the indentation width only within the relevant file-type blocks.

References
  1. Consistency: Be consistent with naming convention, style, and other patterns in the code base. (link)

trim_trailing_whitespace = true
max_line_length = 80

[{BUILD,*.BUILD,*.bzl,*.bazel,.bazelrc,WORKSPACE}]
indent_size = 4
Expand All @@ -38,7 +39,6 @@ indent_size = 4

[{Makefile,makefile,*.mk}]
indent_style = tab
indent_size = 4
Comment thread
mhucka marked this conversation as resolved.
Comment thread
mhucka marked this conversation as resolved.
Comment thread
mhucka marked this conversation as resolved.

[{*.cc,*.h}]
indent_size = 2
Expand Down
Loading