Skip to content

Fix multiple issues in size-labeler.sh #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhucka wants to merge 11 commits into
base: main
Choose a base branch
from
+13 −31
Open

Fix multiple issues in size-labeler.sh #1034

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
64cb3a8
Fix error in pattern matching
mhucka Apr 3, 2026
0d15189
Merge branch 'main' into fix-size-labeler
mhucka Apr 3, 2026
bd2c201
Support > 100 files in size-labeler.sh
mhucka Apr 3, 2026
32a8a87
Performance improvement from Gemini Code Assist
mhucka Apr 3, 2026
de40b72
Remove no-longer-needed variable
mhucka Apr 3, 2026
1132ded
Fix inconsistent label capitalization
mhucka Apr 3, 2026
540d474
Merge branch 'main' into fix-size-labeler
mhucka Apr 5, 2026
760bb24
Merge branch 'main' into fix-size-labeler
mhucka Apr 7, 2026
a6a494b
Merge branch 'main' into fix-size-labeler
mhucka Apr 8, 2026
7289cab
Further simplify `compute_changes()` and remove `IGNORED`
mhucka Apr 24, 2026
849a18f
Merge branch 'main' into fix-size-labeler
mhucka Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dev_tools/ci/size-labeler.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ declare -A LIMITS=(
["${LABELS[4]}"]="$((2 ** 63 - 1))"
)

# Note: these are Bash glob patterns and not regexes.
declare -ar IGNORED=(
"*_pb2.py"
"*_pb2.pyi"
Expand Down Expand Up @@ -114,7 +115,7 @@ function compute_changes() {
local response
local change_info
local -r keys_filter='with_entries(select([.key] | inside(["changes", "filename"])))'
response="$(api_call "pulls/${pr}/files")"
response="$(api_call "pulls/${pr}/files?per_page=100")"
Comment thread
mhucka marked this conversation as resolved.
Outdated
change_info="$(jq_stdin "map(${keys_filter})" <<<"${response}")"

local files total_changes
Expand All @@ -124,7 +125,8 @@ function compute_changes() {
local name changes
name="$(jq_stdin -r '.filename' <<<"${file}")"
for pattern in "${IGNORED[@]}"; do
if [[ "$name" =~ ${pattern} ]]; then
# shellcheck disable=SC2053 # Pattern must be left unquoted here.
if [[ "$name" == ${pattern} ]]; then
info "File $name ignored"
continue 2
fi
Expand Down
Loading