Skip to content

Micro-optimization: replace nested list comprehension in qsim_circuit.py #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhucka wants to merge 2 commits into from
Closed

Micro-optimization: replace nested list comprehension in qsim_circuit.py #1030

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
519d1c6
perf: replace nested list comprehension with for-loop in matrix gate …
mhucka Mar 30, 2026
b47221c
Take Gemini Code Assist's suggestion
mhucka Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions qsimcirq/qsim_circuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,10 @@ def add_op_to_circuit(
time, qsim_qubits, qsim_gate._diag_angles_radians, circuit
)
elif gate_kind == qsim.kMatrixGate:
m = [
val for i in list(cirq.unitary(qsim_gate).flat) for val in [i.real, i.imag]
]
m = []
for i in cirq.unitary(qsim_gate).flat:
m.append(i.real)
m.append(i.imag)
Comment thread
mhucka marked this conversation as resolved.
Outdated
if isinstance(circuit, qsim.Circuit):
qsim.add_matrix_gate(time, qsim_qubits, m, circuit)
else:
Expand Down
Loading