Skip to content

Need setuptools version > 78 in the dev environment too#1013

Merged
mhucka merged 1 commit intoquantumlib:mainfrom
mhucka:setuptools-version
Feb 4, 2026
Merged

Need setuptools version > 78 in the dev environment too#1013
mhucka merged 1 commit intoquantumlib:mainfrom
mhucka:setuptools-version

Conversation

@mhucka
Copy link
Copy Markdown
Collaborator

@mhucka mhucka commented Feb 4, 2026

There was an inconsistency in the version of setuptools specified for the development environment and the run-time requirements. (Mea culpa.) Setuptools > 78 is needed in all cases, not just for python 3.12+.

There was an inconsistency in the version of setuptools specified for
the development environment and the run-time requirements.
@github-actions github-actions Bot added the size: XS <10 lines changed label Feb 4, 2026
@mhucka mhucka marked this pull request as ready for review February 4, 2026 03:02
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an inconsistency in the setuptools version requirement for the development environment. The change in pyproject.toml removes the Python version constraint, making setuptools>=78.1.1 a requirement for all supported Python versions in the dev dependency group. This aligns the development dependencies with the build system requirements, ensuring a consistent and correct environment for developers. The change is correct and I have no further comments.

@mhucka mhucka added this pull request to the merge queue Feb 4, 2026
Merged via the queue into quantumlib:main with commit 3dee003 Feb 4, 2026
28 checks passed
@mhucka mhucka deleted the setuptools-version branch February 4, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants