Create a bloq for Semi-Classical QFT#1610
Closed
NoureldinYosri wants to merge 7 commits intoquantumlib:mainfrom
Closed
Create a bloq for Semi-Classical QFT#1610NoureldinYosri wants to merge 7 commits intoquantumlib:mainfrom
NoureldinYosri wants to merge 7 commits intoquantumlib:mainfrom
Conversation
Contributor
Author
|
@mpharrigan I'm not sure whether this should be bloq or a shim.. if we make it a bloq it will be a good application of your classical control design, what do you think? |
Collaborator
|
Yes, the decomposition requires measurement / feedback, so depends on having that functionality merged. That shouldn't block committing a placeholder with just call graph / resource counts |
mpharrigan
reviewed
Apr 8, 2025
Comment on lines
+41
to
+43
| Args: | ||
| bitsize: Size of the input register to apply QFT on. | ||
| is_adjoint: Whether to apply QFT or QFT†. |
Collaborator
There was a problem hiding this comment.
we usually put Args first
mpharrigan
reviewed
Apr 8, 2025
| is_adjoint: Whether to apply QFT or QFT†. | ||
|
|
||
| References: | ||
| [Semiclassical Fourier Transform for Quantum Computation, Griffiths & Niu](https://arxiv.org/abs/quant-ph/9511007) |
Collaborator
There was a problem hiding this comment.
can you follow the standard reference format https://qualtran.readthedocs.io/en/latest/Autodoc.html#references
[title](url).
author. 2000. Fig x.
mpharrigan
reviewed
Apr 8, 2025
|
|
||
| [Implementation of the Semiclassical Quantum Fourier Transform in a Scalable System](https://www.science.org/doi/10.1126/science.1110335) | ||
|
|
||
| [stackexchange answer, Gidney](https://quantumcomputing.stackexchange.com/a/23712) |
Collaborator
There was a problem hiding this comment.
you can use the stack exchange title as the title
mpharrigan
reviewed
Apr 8, 2025
Comment on lines
+61
to
+62
| t = ssa.new_symbol('t') | ||
| return {Hadamard(): self.bitsize, Measure(): self.bitsize, Rz(t): self.bitsize - 1} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second PR in the series for reproducing https://arxiv.org/abs/1905.09749
followup to #1602