Remove left-over Python 2-isms#1283
Draft
mhucka wants to merge 5 commits intoquantumlib:mainfrom
Draft
Conversation
mhucka
added
area/health
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modernizes the codebase by removing legacy Python 2 compatibility artifacts. Key changes include transitioning to Python 3 class definitions by removing explicit inheritance from 'object', updating 'super()' calls to the simplified Python 3 syntax, and removing 'u' prefixes from string literals. Additionally, the pylint configuration and imports have been cleaned up to remove references to compatibility libraries like 'six' and 'future'. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes Python 2 compatibility shims and constructs that were not addressed in a previous PR to remove Python 2 shims.
Removed
from builtins import map, zipinsrc/openfermion/utils/operator_utils.py. These were legacy imports from thefuturelibrary to provide Python 3 behavior in Python 2.Removed explicit
(object)inheritance from all class definitions.Removed the redundant
uprefix from string literals, because in Python 3, all strings are Unicode by default.