Simplify and streamline ci.yaml#1271
Merged
mhucka merged 30 commits intoquantumlib:mainfrom Apr 19, 2026
Merged
Conversation
I never used it and I doubt anyone else did. Remove it to simplify the workflow and improve maintainability.
Another thing I never ended up using.
A bit much.
It's better to pass all the "-r foo.txt" files to `pip install` at once, because then it can do better dependency resolution. Plus, it's faster overall.
Instead of using the CLI version of the `actionlint` and having to run it in a MacOS runner, we can use the GHA action.
Where possible, just include the step as part of the step that invokes the command.
For jobs that are not too heavy, the `ubuntu-slim` runners are less expensive and startup faster.
It doesn't seem to help speed things up. The places that need to install requirements install them anyway. Let's try skipping this job.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This is more efficient and simplier.
This makes it possible to avoid having to list the individual jobs in the branch status checks; instead, the branch check can be for just the job `CI`. And thanks to that, we can also skip the matrix job reporting steps, and further simplify this workflow.
The problem matcher files are not essential.
YAML file linting is good enough.
The `gha` filter is meant to catch those.
No longer needed.
Try to make them easier to read in the GitHub actions page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This overhauls the CI workflow file to simplify it, remove unnecessary or unused parts, and try to make it more efficient.