Conversation
On line 72, the variable eri_kpt is assigned to itself. It's not clear what it should be instead – either something is missing on the RHS or else it's just a pointless assignment.
```python
if dtype == float:
eri_kpt = eri_kpt.real
eri_kpt = eri_kpt
```
fdmalone
approved these changes
Jun 2, 2025
dstrain115
approved these changes
Jun 2, 2025
mhucka
added a commit
to mhucka/OpenFermion
that referenced
this pull request
Sep 25, 2025
On line 72, the variable eri_kpt is assigned to itself. It's not clear
what it should be instead – either something is missing on the RHS or
else it's just a pointless assignment.
```python
if dtype == float:
eri_kpt = eri_kpt.real
eri_kpt = eri_kpt
```
Resolves issue quantumlib#926.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On line 72, the variable eri_kpt is assigned to itself. It's not clear what it should be instead – either something is missing on the RHS or else it's just a pointless assignment.
Resolves issue #926.