Replace: np.string_ -> np.byte_#1010
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@JerryChen97 Thank you for this. I'd like to merge the changes, but before that can be done, we need you to sign off on the contributor's license agreement. Could you please check this page and follow the instructions? https://github.com/quantumlib/OpenFermion/pull/1010/checks?check_run_id=38741050105 |
|
@mhucka Thanks a lot for reminder! I'm right now employee of another company which also features SSO therefore I'm not sure if it is proper for me to directly sign it. But I can sign this on behalf of myself during my after-work time. |
|
For the CI failures I'll suggest a replacement |
|
Thank you for your efforts. I've worked on NumPy 2 compatibility and this PR is subsumed by new PR #1057. Consequently, I'm going to close this one. |
Context:
The usage of
numpy.string_caused quite some trouble for users with NumPy 2.xHopefully a direct replacement with
byte_can help a little bit.