Fix bug in circuit.insert.

[codrut3]

Change _group_into_moment_compatible to take into account measurement and control keys. Otherwise two incompatible operations can be put in the same moment.
I also changed _can_add_op_at to look at measurement and control keys.
I added unit tests that show the issue.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (ceb9432) to head (b11b2de).
⚠️ Report is 128 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7823      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        1102     1102              
  Lines       98772    98828      +56     
==========================================
+ Hits        98352    98407      +55     
- Misses        420      421       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[daxfohl]

Allowing multiple measurements to the same key in the same moment was a requirement from the HW team. Unless that has changed, this would be breaking.

[codrut3]

Thank you for pointing this out @daxfohl ! Doesn't this mean this condition here is also wrong:

Cirq/cirq-core/cirq/circuits/circuit.py

Line 2146 in ceb9432

not op_measurement_keys.isdisjoint(moment_measurement_keys)

[daxfohl]

Maybe. Though it can't be removed completely, because then it could fall through to earlier moments and break commutativity. (There's a lot of https://xkcd.com/1172/ in the circuit construction code).

[pavoljuhas]

cirq-cync - @codrut3 - please create an issue for this PR, e.g., to request that measurement and control keys cannot overlap in the same moment. This would be potentially a breaking change so request feedback from Ilya Drozdov and Christopher Wood for the issue to comment if the current behavior is needed in some situations.

[codrut3]

Thank you! I created #7829

[github-actions]

This pull request has been automatically labeled as stale because 90 days have passed without activity. If no further activity occurs and the status/stale label is not removed by a maintainer within 60 days, this pull request will be closed. If you want to keep the pull request open, leave a comment here and the status will be updated automatically.

If you have questions or feedback about this process, please open a new issue in this repository to let us know. You can also send email to the maintainers at quantum-oss-maintainers@google.com.